Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Revise and expand Joy UI "Breadcrumbs" page #35292

Merged
merged 11 commits into from Dec 1, 2022
Merged

[docs] Revise and expand Joy UI "Breadcrumbs" page #35292

merged 11 commits into from Dec 1, 2022

Conversation

samuelsycamore
Copy link
Member

Part of #33998

This PR revises and expands the Joy UI "Breadcrumbs" page. Notable changes include:

  • updated page structure and formatting
  • revised intro
  • added size demo
  • updated existing demos - hierarchical dummy data, wrapped comments to eliminate horizontal scroll
  • added anatomy section
  • renamed "collapsed" demos to "condensed" to match commonly accepted naming conventions

@samuelsycamore samuelsycamore added component: breadcrumbs This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy labels Nov 29, 2022
@mui-bot
Copy link

mui-bot commented Nov 29, 2022 •
edited

Messages
📖 Netlify deploy preview: https://deploy-preview-35292--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against 1173389

siriwatknp
siriwatknp approved these changes Nov 30, 2022
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Well written. ❣️

samuelsycamore and others added 2 commits November 30, 2022 11:49
@samuelsycamore @siriwatknp
Apply suggestions from code review
51c61c9 
Co-authored-by: Siriwat K <siriwatkunaporn@gmail.com>
Signed-off-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
@samuelsycamore
update demo name
1173389
@samuelsycamore samuelsycamore mentioned this pull request Nov 30, 2022
Open
61 tasks
@samuelsycamore samuelsycamore merged commit 1ea442d into mui:master Dec 1, 2022
feliperli pushed a commit to jesrodri/material-ui that referenced this pull request Dec 6, 2022
@samuelsycamore @siriwatknp
[docs] Revise and expand Joy UI "Breadcrumbs" page (mui#35292)
83348d4 
Signed-off-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Co-authored-by: Siriwat K <siriwatkunaporn@gmail.com>
@samuelsycamore samuelsycamore deleted the joy-bread branch April 3, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

@danilo-leal danilo-leal Awaiting requested review from danilo-leal

Assignees
No one assigned
Labels
component: breadcrumbs This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@samuelsycamore @mui-bot @siriwatknp