New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Improve spacing with ul #35302
[docs] Improve spacing with ul #35302
Conversation
|
c37b05c
to
8db5501
Compare
8db5501
to
544ff64
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new spacing looks pretty good but the color removal looks like a regression to me, especially in dark mode, as everything is now totally white⎯ very hard to read. Maybe the place where the color was being defined was not the best (?) but I definitely wouldn't remove the current text color styling.
@danilo-leal Oh, I didn't realize that this change would lead to a visual difference. Great catch. Reverting, I thought that it was an unnecessary CSS property override and that we could rely on CSS inheritance, the goal was to do a cleanup along the way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet⎯now looking great. Indeed more comfortable to read with larger spacing between lines 👌
Before: https://mui.com/material-ui/getting-started/overview/#advantages-of-material-ui
After: https://deploy-preview-35302--material-ui.netlify.app/material-ui/getting-started/overview/#advantages-of-material-ui
Before: https://mui.com/joy-ui/customization/using-css-variables/#raw-value
After https://deploy-preview-35302--material-ui.netlify.app/joy-ui/customization/using-css-variables/#raw-value
Remove useless color override, use CSS inheritance by default