Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Improve spacing with ul #35302

Merged
merged 2 commits into from Dec 5, 2022

Conversation

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation design This is about UI or UX design, please involve a designer scope: docs-infra Specific to the docs-infra product labels Nov 30, 2022
@mui-bot
Copy link

mui-bot commented Nov 30, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-35302--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against d2dec51

Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new spacing looks pretty good but the color removal looks like a regression to me, especially in dark mode, as everything is now totally white⎯ very hard to read. Maybe the place where the color was being defined was not the best (?) but I definitely wouldn't remove the current text color styling.

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Dec 3, 2022

the color removal looks like a regression to me, especially in dark mode, as everything is now totally white⎯ very hard to read

@danilo-leal Oh, I didn't realize that this change would lead to a visual difference. Great catch. Reverting, I thought that it was an unnecessary CSS property override and that we could rely on CSS inheritance, the goal was to do a cleanup along the way.
I have the same experience as you had: it feels much better in dark mode with lighter color text.

Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet⎯now looking great. Indeed more comfortable to read with larger spacing between lines 👌

@oliviertassinari oliviertassinari merged commit f4be7ab into mui:master Dec 5, 2022
@oliviertassinari oliviertassinari deleted the improve-markdown-look branch December 5, 2022 17:12
tchassijordan pushed a commit to tchassijordan/material-ui that referenced this pull request Dec 5, 2022
feliperli pushed a commit to jesrodri/material-ui that referenced this pull request Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design This is about UI or UX design, please involve a designer docs Improvements or additions to the documentation scope: docs-infra Specific to the docs-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants