Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Fix warning leak in production #35313

Merged
merged 1 commit into from Dec 3, 2022

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Dec 1, 2022

I found this by chance looking in the source of https://databar.ai/static/js/4.29980672.chunk.js for https://groups.google.com/a/mui.com/g/core/c/vipNV4kM7k0.

It diverges from the standard of how we add warnings.

@oliviertassinari oliviertassinari added performance core Infrastructure work going on behind the scenes labels Dec 1, 2022
@mui-bot
Copy link

mui-bot commented Dec 1, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-35313--material-ui.netlify.app/

@material-ui/core: parsed: -0.07% 😍, gzip: -0.14% 😍

Details of bundle changes

Generated by 🚫 dangerJS against 836ced8

@oliviertassinari oliviertassinari merged commit d87f019 into mui:master Dec 3, 2022
@oliviertassinari oliviertassinari deleted the fix-bundle-size-leak branch December 3, 2022 12:20
feliperli pushed a commit to jesrodri/material-ui that referenced this pull request Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants