Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rating] Apply labelEmptyValueActive style overrides from theme #35315

Merged
merged 18 commits into from Dec 5, 2022
Merged

[Rating] Apply labelEmptyValueActive style overrides from theme #35315

merged 18 commits into from Dec 5, 2022

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Dec 1, 2022 •
edited by ZeeshanTamboli

@mui-bot
Copy link

mui-bot commented Dec 1, 2022 •
edited

Messages
📖 Netlify deploy preview: https://deploy-preview-35315--material-ui.netlify.app/

Details of bundle changes

Generated by 🚫 dangerJS against c55b2c6

@sai6855 sai6855 mentioned this pull request Dec 2, 2022
Closed
2 tasks
@zannager zannager added the component: rating This is the name of the generic UI component, not the React module! label Dec 2, 2022
@ZeeshanTamboli ZeeshanTamboli added the bug 🐛 Something doesn't work label Dec 3, 2022
@ZeeshanTamboli ZeeshanTamboli changed the title [Rating] apply labelEmptyValueActive styles from theme [Rating] Apply labelEmptyValueActive styles from theme Dec 3, 2022
@sai6855 sai6855 requested review from ZeeshanTamboli and removed request for siriwatknp December 3, 2022 12:00
@sai6855
Copy link
Contributor Author

sai6855 commented Dec 3, 2022

@ZeeshanTamboli i've updated test case as described

sai6855 and others added 2 commits December 3, 2022 17:56
@sai6855 @ZeeshanTamboli
Update packages/mui-material/src/Rating/Rating.test.js
4def96d 
Co-authored-by: Zeeshan Tamboli <zeeshan.tamboli@gmail.com>
Signed-off-by: sai6855 <60743144+sai6855@users.noreply.github.com>
@sai6855
update test
55f01a5
@sai6855
Copy link
Contributor Author

sai6855 commented Dec 3, 2022

@ZeeshanTamboli done

@ZeeshanTamboli ZeeshanTamboli changed the title [Rating] Apply labelEmptyValueActive styles from theme [Rating] Apply labelEmptyValueActive style overrides from theme Dec 3, 2022
@sai6855
Copy link
Contributor Author

sai6855 commented Dec 3, 2022

@ZeeshanTamboli after merging master branch, regression test is failing. tried to retrigger CI but didn't worked, test is still failing

ZeeshanTamboli
ZeeshanTamboli approved these changes Dec 5, 2022
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the fix!

@ZeeshanTamboli ZeeshanTamboli merged commit 5ca6df8 into mui:master Dec 5, 2022
feliperli pushed a commit to jesrodri/material-ui that referenced this pull request Dec 6, 2022
@sai6855 @ZeeshanTamboli
[Rating] Apply labelEmptyValueActive style overrides from theme (mu…
af40784 
…i#35315)

Signed-off-by: sai6855 <60743144+sai6855@users.noreply.github.com>
Co-authored-by: Zeeshan Tamboli <zeeshan.tamboli@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeeshanTamboli ZeeshanTamboli ZeeshanTamboli approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: rating This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rating - labelEmptyValueActive styles are not applied
4 participants
@sai6855 @mui-bot @ZeeshanTamboli @zannager