[core] Convert the waterfall module to an internal package #35323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
michaldudak
force-pushed
the
waterfall-package
branch
from
7efc6fd
to
e40b9c9
Compare
mnajdova
reviewed
Dec 2, 2022
packages/waterfall/package.json
Outdated
| @@ -0,0 +1,7 @@ | |||
| { | |||
| "name": "@mui-internal/waterfall", | |||
There was a problem hiding this comment.
Suggested change
| "name": "@mui-internal/waterfall", | |
| "name": "@mui/internal-waterfall", |
Would this be better? To have the same org name
There was a problem hiding this comment.
Sure, I'm OK with both.
There was a problem hiding this comment.
There are other packages that use the @mui-internal scope. I'll rename them in a separate PR.
mnajdova
reviewed
Feb 7, 2023
| @@ -0,0 +1,7 @@ | |||
| { | |||
| "name": "@mui/internal-waterfall", | |||
| "version": "1.0.0", | |||
There was a problem hiding this comment.
Usually we use "5.0.0" for the private packages, but we can do the change once for all packages in a follow up PR.
mnajdova
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a part of the scripts cleanup.
This PR moves the content of
/modules/waterfallto/packages/waterfalland creates an internal@mui/internal-waterfallpackage out of it.It removes the top level
modulesdirectory and simplifies a few imports.