[Utils] mergedeep deeply clones source key if it's an object #35364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yurisldk
force-pushed
the
fix/deepmerge
branch
from
5529b78
to
e8b77ff
Compare
packages/mui-utils/src/deepmerge.ts
Outdated
| @@ -1,3 +1,5 @@ | |||
| import cloneDeep from 'lodash/cloneDeep'; | |||
There was a problem hiding this comment.
lodash is a no go.
Suggested change
| import cloneDeep from 'lodash/cloneDeep'; |
There was a problem hiding this comment.
@oliviertassinari I'm agree, it has been added to illustrate an solution and check that all tests will be passed. Should we write own implementation of clonedeep or do we have other ways?
yurisldk
force-pushed
the
fix/deepmerge
branch
from
e8b77ff
to
9776461
Compare
yurisldk
commented
Dec 6, 2022
packages/mui-utils/src/deepmerge.ts
Outdated
Comment on lines
9
to
22
| function clonedeep<T>(source: T): T | Record<keyof any, unknown> { | ||
| if (!isPlainObject(source)) { | ||
| return source; | ||
| } | ||
|
|
||
| const output: Record<keyof any, unknown> = {}; | ||
|
|
||
| Object.keys(source).forEach((key) => { | ||
| output[key] = clonedeep(source[key]); | ||
| }); | ||
|
|
||
| return output; | ||
| } | ||
|
|
There was a problem hiding this comment.
@oliviertassinari Seems that this implementation fits well, all tests passed and code coverage is happy.
michaldudak
reviewed
Dec 19, 2022
packages/mui-utils/src/deepmerge.ts
Outdated
| @@ -6,6 +6,20 @@ export interface DeepmergeOptions { | |||
| clone?: boolean; | |||
| } | |||
|
|
|||
| function clonedeep<T>(source: T): T | Record<keyof any, unknown> { | |||
There was a problem hiding this comment.
Could you call this function deepClone? I know that deepmerge doesn't follow conventions (should be deepMerge), but let's ensure new functions are named consistently with most of the code.
yurisldk
force-pushed
the
fix/deepmerge
branch
2 times, most recently
from
6b041aa
to
a9a5287
Compare
yurisldk
force-pushed
the
fix/deepmerge
branch
from
a9a5287
to
34dd04d
Compare
|
@michaldudak @oliviertassinari branch is updated and ready for review. Thank you. |
yurisldk
requested review from
michaldudak and
oliviertassinari
and removed request for
oliviertassinari and
michaldudak
michaldudak
approved these changes
Dec 20, 2022
michaldudak
changed the title
michaldudak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure about
lodashbut we definetly have to use deep copy for objects otherwise value assign by reference.Test case has been added.
Fix #35363