[docs][Joy] Add documentation for Joy Grid component
#35374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbjORbj
added
docs
|
hbjORbj
force-pushed
the
docs/joy-grid
branch
from
73cb6fa
to
cef9bff
Compare
siriwatknp
reviewed
Dec 8, 2022
siriwatknp
reviewed
Dec 8, 2022
siriwatknp
reviewed
Dec 8, 2022
hbjORbj
force-pushed
the
docs/joy-grid
branch
from
e803fe2
to
9a17bb4
Compare
siriwatknp
requested changes
Dec 19, 2022
There was a problem hiding this comment.
- Please follow the Table of contents structure from the page that @samuelsycamore has done, .e.g. the AspectRatio page.
- The
Interactive demodoes not look good.
- Let's remove the "Complex Grid" demo. I don't think it is a good example.
https://deploy-preview-35374--material-ui.netlify.app/material-ui/react-grid2/#customization - Add these examples similar to the Material UI Grid v2 to show the common examples.
|
I added a common example that shows how to center children of grid item and how to set borders on grid. I am open for suggestions. |
siriwatknp
reviewed
Dec 22, 2022
hbjORbj
force-pushed
the
docs/joy-grid
branch
from
da40f26
to
7e0f416
Compare
siriwatknp
reviewed
Dec 26, 2022
siriwatknp
reviewed
Dec 26, 2022
siriwatknp
approved these changes
Dec 26, 2022
github-actions
bot
added
the
PR: out-of-date
hbjORbj
force-pushed
the
docs/joy-grid
branch
from
3f44872
to
f07b834
Compare
github-actions
bot
removed
the
PR: out-of-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview: https://deploy-preview-35374--material-ui.netlify.app/joy-ui/react-grid