Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Refactor ToggleButtonSizes demo #35375

Merged
merged 3 commits into from Dec 8, 2022
Merged

[docs] Refactor ToggleButtonSizes demo #35375

merged 3 commits into from Dec 8, 2022

Conversation

Armanio
Copy link
Contributor

@Armanio Armanio commented Dec 6, 2022

Signed-off-by: Arman mail@arman.io

@Armanio
[docs] Refactor ToggleGroupSizes example
2c4a1f3 
Signed-off-by: Arman <mail@arman.io>
@mui-bot
Copy link

mui-bot commented Dec 6, 2022 •
edited

Messages
📖 Netlify deploy preview: https://deploy-preview-35375--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against 473f716

@zannager zannager added the docs Improvements or additions to the documentation label Dec 7, 2022
ZeeshanTamboli
ZeeshanTamboli reviewed Dec 7, 2022
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but can you instead refactor in ToggleButtonSizes.tsx (TypeScript file) and then run yarn docs:typescript:formatted to update the js file?

@ZeeshanTamboli ZeeshanTamboli added the component: toggle button This is the name of the generic UI component, not the React module! label Dec 7, 2022
@ZeeshanTamboli ZeeshanTamboli changed the title [docs] Refactor ToggleGroupSizes example [docs] Refactor ToggleButtonSizes example Dec 8, 2022
@ZeeshanTamboli ZeeshanTamboli changed the title [docs] Refactor ToggleButtonSizes example [docs] Refactor ToggleButtonSizes demo Dec 8, 2022
ZeeshanTamboli
ZeeshanTamboli approved these changes Dec 8, 2022
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a great first pull request on Material UI 👌 Thank you for working on it!

@ZeeshanTamboli ZeeshanTamboli merged commit 88f8147 into mui:master Dec 8, 2022
@Armanio Armanio deleted the patch-3 branch December 8, 2022 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeeshanTamboli ZeeshanTamboli ZeeshanTamboli approved these changes

Assignees
No one assigned
Labels
component: toggle button This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Armanio @mui-bot @ZeeshanTamboli @zannager