Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add a guide on using icon libraries with Joy UI #35377

Merged
merged 10 commits into from Dec 26, 2022
Merged

[docs] Add a guide on using icon libraries with Joy UI #35377

merged 10 commits into from Dec 26, 2022

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Dec 7, 2022 •
edited

@siriwatknp siriwatknp added docs Improvements or additions to the documentation design: joy This is about Joy Design, please involve a visual or UX designer in the process labels Dec 7, 2022
@mui-bot
Copy link

mui-bot commented Dec 7, 2022 •
edited

Messages
📖 Netlify deploy preview: https://deploy-preview-35377--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against ce6b6f3

@danilo-leal danilo-leal added package: joy-ui Specific to @mui/joy and removed design: joy This is about Joy Design, please involve a visual or UX designer in the process labels Dec 8, 2022
samuelsycamore
samuelsycamore reviewed Dec 8, 2022
View reviewed changes
Copy link
Member

@samuelsycamore samuelsycamore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Just some minor style and grammar suggestions here.

docs/data/joy/guides/using-icon-libraries/using-icon-libraries.md Outdated Show resolved Hide resolved
docs/data/joy/guides/using-icon-libraries/using-icon-libraries.md Outdated Show resolved Hide resolved
docs/data/joy/guides/using-icon-libraries/using-icon-libraries.md Outdated Show resolved Hide resolved
docs/data/joy/guides/using-icon-libraries/using-icon-libraries.md Outdated Show resolved Hide resolved
docs/data/joy/guides/using-icon-libraries/using-icon-libraries.md Outdated Show resolved Hide resolved
docs/data/joy/guides/using-icon-libraries/using-icon-libraries.md Outdated Show resolved Hide resolved
docs/data/joy/guides/using-icon-libraries/using-icon-libraries.md Outdated Show resolved Hide resolved
docs/data/joy/guides/using-icon-libraries/using-icon-libraries.md Outdated Show resolved Hide resolved
docs/data/joy/guides/using-icon-libraries/using-icon-libraries.md Outdated Show resolved Hide resolved
docs/data/joy/guides/using-icon-libraries/using-icon-libraries.md Outdated Show resolved Hide resolved
@siriwatknp @samuelsycamore
Apply suggestions from code review
da2d240 
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Signed-off-by: Siriwat K <siriwatkunaporn@gmail.com>
This was referenced Dec 9, 2022
Open
Closed
@siriwatknp siriwatknp merged commit 5344adb into mui:master Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

@samuelsycamore samuelsycamore Awaiting requested review from samuelsycamore

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@siriwatknp @mui-bot @mnajdova @samuelsycamore @danilo-leal