Skip to content

[core] Migrate all the internals exported by tests/utils/index.js to TypeScript #35382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Feb 13, 2023
Merged

[core] Migrate all the internals exported by tests/utils/index.js to TypeScript #35382

merged 10 commits into from
Feb 13, 2023
+74 −157

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Dec 7, 2022 •
edited
Loading

I also removed getClasses and createShallow which were not used anywhere.
If you think it is to risky, I can add them back

oliviertassinari and others added 5 commits April 18, 2022 11:47
@oliviertassinari
disable indexation

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
a2d3a00
@m4theushw
Merge branch 'master' into next
2be4949
@m4theushw
Merge branch 'master' into next
71e2187
@m4theushw @oliviertassinari
[docs] Add redirects for MUI X v6 (mui#34296)
fbc0d82 
Signed-off-by: Matheus Wichman <matheushw@outlook.com>
Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
@oliviertassinari
[docs] Handle static files
3919518
@flaviendelangle flaviendelangle added the core Infrastructure work going on behind the scenes label Dec 7, 2022
@flaviendelangle flaviendelangle self-assigned this Dec 7, 2022
@flaviendelangle flaviendelangle force-pushed the typescript-test-internals branch from d752d4d to 915874c Compare December 7, 2022 13:02
@mui-bot
Copy link

mui-bot commented Dec 7, 2022 •
edited
Loading

Netlify deploy preview

No updates.

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against 3d9f522

@flaviendelangle flaviendelangle marked this pull request as ready for review December 7, 2022 13:24
@flaviendelangle flaviendelangle changed the title [core] Migrate all the internals exported by to TypeScript [core] Migrate all the internals exported by tests/utils/index.js to TypeScript Dec 7, 2022
michaldudak
michaldudak reviewed Dec 8, 2022
View reviewed changes
michaldudak
michaldudak reviewed Dec 9, 2022
View reviewed changes
@mnajdova mnajdova removed their request for review December 13, 2022 11:46
@mnajdova
Copy link
Member

I also removed getClasses and createShallow which were not used anywhere.
If you think it is to risky, I can add them back

If they are not used anywhere, I am good with it. Will leave the review to @michaldudak :)

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Dec 23, 2022
@flaviendelangle
Copy link
Member Author

@michaldudak if you can have a look

@michaldudak
Copy link
Member

Looks OK, tests pass, ship it!

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 10, 2023
@michaldudak michaldudak merged commit 3fbf472 into mui:master Feb 13, 2023
@flaviendelangle flaviendelangle deleted the typescript-test-internals branch February 13, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaldudak michaldudak

Assignees

@flaviendelangle flaviendelangle

Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@flaviendelangle @mui-bot @mnajdova @michaldudak @oliviertassinari @m4theushw