[Material You] Add motion design tokens #35384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mui/material-next: parsed: +0.88% , gzip: +0.67% |
mnajdova
commented
Dec 7, 2022
github-actions
bot
added
the
PR: out-of-date
Signed-off-by: Marija Najdova <mnajdova@gmail.com>
github-actions
bot
removed
the
PR: out-of-date
siriwatknp
reviewed
Dec 13, 2022
| @@ -13,7 +13,8 @@ import defaultTheme from './defaultTheme'; | |||
|
|
|||
| const shouldSkipGeneratingVar = (keys: string[]) => | |||
| !!keys[0].match(/(typography|mixins|breakpoints|direction|transitions)/) || | |||
| (keys[0] === 'palette' && !!keys[1]?.match(/(mode|contrastThreshold|tonalOffset)/)); | |||
| (keys[0] === 'palette' && !!keys[1]?.match(/(mode|contrastThreshold|tonalOffset)/)) || | |||
| (keys[0] === 'motion' && !!keys[1]?.match(/(create|getAutoHeightDuration)/)); | |||
There was a problem hiding this comment.
Suggested change
| (keys[0] === 'motion' && !!keys[1]?.match(/(create|getAutoHeightDuration)/)); |
The function will be skipped by default, no need to put them here.
There was a problem hiding this comment.
Ah, I didn't know that, alright then I will just not add the motion key anywhere :)
siriwatknp
approved these changes
Dec 13, 2022
mnajdova
commented
Dec 13, 2022
Signed-off-by: Marija Najdova <mnajdova@gmail.com>
github-actions
bot
added
the
PR: out-of-date
Signed-off-by: Marija Najdova <mnajdova@gmail.com>
github-actions
bot
removed
the
PR: out-of-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference - https://m3.material.io/styles/motion/easing-and-duration/tokens-specs