[docs] Improve line-height readability #35387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
docs
oliviertassinari
commented
Dec 7, 2022
| @@ -143,7 +143,6 @@ const Root = styled('div')( | |||
| marginBottom: theme.spacing(3), | |||
| }, | |||
| '& .markdown-body': { | |||
| fontSize: theme.typography.pxToRem(16), | |||
There was a problem hiding this comment.
Duplicate with the default value.
oliviertassinari
commented
Dec 7, 2022
| @@ -10,6 +10,7 @@ import { | |||
| const Root = styled('div')( | |||
| ({ theme }) => ({ | |||
| ...lightTheme.typography.body1, | |||
| lineHeight: 1.625, | |||
There was a problem hiding this comment.
the default is 1.5, 24 pixels, this is 26 pixels.
|
danilo-leal
approved these changes
Dec 8, 2022
There was a problem hiding this comment.
Definitely reads better, sweet improvement! I'm not particularly bothered by the chosen value but it does feel like an isolated one rather than a point on a scale. cc @gerdadesign something to consider adding to the branding theme in a systematized way!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A nitpick, a quick follow-up on https://groups.google.com/a/mui.com/g/design/c/S5t9m6klH7o.
The idea of this change is to bring a bit more space between each line of the docs. Right now, if you compare our line height of Tailwind CSS, https://mintlify.com/docs/quickstart or https://stripe.com/docs/billing/subscriptions/overview it seems that the new value match closer, and might be more enjoyable to read.
For the blog, maybe it makes sense to have a bit more line height?