-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Update callouts design #35390
Conversation
@danilo-leal Sounds good. How about adding :::info-icon
Some content
::: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, you might want to remove the .gitignore
change 😅.
That's a great idea! I was thinking it would be nice to have the option not to include an icon in certain situations. |
…l-ui into callouts-design-bump
…/material-ui into callouts-design-bump" This reverts commit 6ed8aa8, reversing changes made to 306a3f5.
Sweet, totally agree with both having the icons and the optionally of not having them for specific use-cases 👍 |
|
@samuelsycamore Me too, but then we need to change all of the current callouts to not include the icon which will be a huge PR. |
@siriwatknp Let me know when this PR is ready to go! The icons should probably be implemented in a separate one 😬 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM. I pushed an update for the alpha color.
In light of Sam's recent callout content standardization (#35361), thought about doing some light updates on their design. It's worth highlighting the
info
variant, that now it's way more subtle & grayish, which is to be different from the code block. @siriwatknp one interesting upgrade we should think about doing is displaying icons by default⎯just a container with text seems not enough to stand out on the documentation block of text, and the icons might help exactly with that!Preview link:
https://deploy-preview-35390--material-ui.netlify.app/experiments/docs/callouts/