[Material You] Add shape design tokens #35393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnajdova
added
customization: theme
@mui/material-next: parsed: +0.34% , gzip: +0.38% |
mnajdova
commented
Dec 8, 2022
mnajdova
commented
Dec 8, 2022
| @@ -1,4 +1,6 @@ | |||
| const mdSysState = { | |||
| import { MD3State } from './Theme.types'; | |||
There was a problem hiding this comment.
The file name was not following the convention for matching the theme's key, which is singular.
siriwatknp
reviewed
Dec 9, 2022
siriwatknp
reviewed
Dec 9, 2022
siriwatknp
reviewed
Dec 9, 2022
Co-authored-by: Siriwat K <siriwatkunaporn@gmail.com> Signed-off-by: Marija Najdova <mnajdova@gmail.com>
Co-authored-by: Siriwat K <siriwatkunaporn@gmail.com> Signed-off-by: Marija Najdova <mnajdova@gmail.com>
mnajdova
commented
Dec 12, 2022
Signed-off-by: Marija Najdova <mnajdova@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference to the spec - https://m3.material.io/styles/shape/shape-scale-tokens.
The
fulldesign token didn't have a specific value in the spec, so I used the value from Figma (100px).