Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Select] Fix MenuProps.PopoverClasses being overriden #35394

Merged
merged 3 commits into from
Dec 9, 2022
Merged

[Select] Fix MenuProps.PopoverClasses being overriden #35394

merged 3 commits into from
Dec 9, 2022
+14 −1

Conversation

vitorfrs-dev
Copy link
Contributor

@vitorfrs-dev vitorfrs-dev commented Dec 8, 2022 •
edited by ZeeshanTamboli
Loading

Fixes #35376

Sorry, something went wrong.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Dec 8, 2022
@vitorfrs-dev vitorfrs-dev force-pushed the fix/Select-menu-classes-overriding-menu-popover-classes branch from 6c81d37 to 5c56ebd Compare December 8, 2022 16:43
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Dec 8, 2022
@mui-bot
Copy link

mui-bot commented Dec 8, 2022 •
edited
Loading

Messages
📖 Netlify deploy preview: https://deploy-preview-35394--material-ui.netlify.app/

Details of bundle changes

Generated by 🚫 dangerJS against 50ee195

@vitorfrs-dev vitorfrs-dev force-pushed the fix/Select-menu-classes-overriding-menu-popover-classes branch from 5c56ebd to a6cf703 Compare December 8, 2022 17:13
@vitorfrs-dev
[Select] Fix PopoverClasses being overriding

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
7ff5c08
@vitorfrs-dev vitorfrs-dev force-pushed the fix/Select-menu-classes-overriding-menu-popover-classes branch from a6cf703 to 7ff5c08 Compare December 8, 2022 17:22
@vitorfrs-dev vitorfrs-dev changed the title [Select] Fix PopoverClasses being overriding [Select] Fix PopoverClasses being override Dec 8, 2022
ZeeshanTamboli
ZeeshanTamboli previously requested changes Dec 9, 2022
View reviewed changes
@ZeeshanTamboli ZeeshanTamboli changed the title [Select] Fix PopoverClasses being override [Select] Fix MenuProps.PopoverClasses being overriden Dec 9, 2022
@ZeeshanTamboli ZeeshanTamboli added bug 🐛 Something doesn't work component: menu This is the name of the generic UI component, not the React module! component: select This is the name of the generic UI component, not the React module! labels Dec 9, 2022
@ZeeshanTamboli ZeeshanTamboli dismissed their stale review December 9, 2022 12:16

Changes applied

ZeeshanTamboli
ZeeshanTamboli approved these changes Dec 9, 2022
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! It's a great first pull request on MUI 👌 Thank you for working on it!

@ZeeshanTamboli ZeeshanTamboli merged commit 6a08da1 into mui:master Dec 9, 2022
@vitorfrs-dev vitorfrs-dev deleted the fix/Select-menu-classes-overriding-menu-popover-classes branch December 9, 2022 13:30
@stefanorie
Copy link
Contributor

I don't know if I should open a new issue or not, however this now breaks the usage of classes on the Menu component. We passed down some styling for paper, which is completely ignored now. Changing classes to PopoverClasses does work, but it's not common to use it like that I guess.

With these changes classes is overriden by PopoverClasses it seems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeeshanTamboli ZeeshanTamboli

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: menu This is the name of the generic UI component, not the React module! component: select This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Select] MenuProps.PopoverClasses does not work in conjunction with MenuProps.classes
4 participants
@vitorfrs-dev @mui-bot @stefanorie @ZeeshanTamboli