Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[website] Developer survey 2022 #35407

Merged
merged 21 commits into from Dec 12, 2022
Merged

[website] Developer survey 2022 #35407

merged 21 commits into from Dec 12, 2022

Conversation

joserodolfofreitas
Copy link
Member

@joserodolfofreitas joserodolfofreitas commented Dec 9, 2022 •
edited by oliviertassinari

Summary

Add callout to take the Developer survey 2022.

  • Add a top banner on the main website
  • Add a side banner on the docs.
  • Add a notification for the docs.

Preview

Website:
https://deploy-preview-35407--material-ui.netlify.app/

Docs:
https://deploy-preview-35407--material-ui.netlify.app/material-ui/getting-started/overview/

Note

Alternatively to replacing the hiring ad, we can use the top banner by toggling the switches in the featureToggle.js file.

@joserodolfofreitas joserodolfofreitas added docs Improvements or additions to the documentation website Pages that are not documentation-related, marketing-focused. labels Dec 9, 2022
@mui-bot
Copy link

mui-bot commented Dec 9, 2022 •
edited

Messages
📖 Netlify deploy preview: https://deploy-preview-35407--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against ba74077

mnajdova
mnajdova reviewed Dec 9, 2022
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

We should fix the contrast on hover on the banner on home page.

docs/src/components/banner/AppHeaderBanner.tsx Outdated Show resolved Hide resolved
docs/src/modules/components/AppTableOfContents.js Outdated Show resolved Hide resolved
joserodolfofreitas and others added 2 commits December 9, 2022 14:21
@joserodolfofreitas @mnajdova
Apply Marija's suggestions from code review
70f99ad 
Co-authored-by: Marija Najdova <mnajdova@gmail.com>
Signed-off-by: José Rodolfo Freitas <joserodolfo.freitas@gmail.com>
@joserodolfofreitas
fix link onhover
1383222
@joserodolfofreitas
Copy link
Member Author

joserodolfofreitas commented Dec 9, 2022 •
edited

We should fix the contrast on hover on the banner on home page.

Thank you for the catch, @mnajdova!
It's done.

oliviertassinari
oliviertassinari reviewed Dec 9, 2022
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

docs/src/route.ts Outdated Show resolved Hide resolved
docs/src/featureToggle.js Outdated Show resolved Hide resolved
docs/src/featureToggle.js Show resolved Hide resolved
oliviertassinari
oliviertassinari reviewed Dec 11, 2022
View reviewed changes
docs/src/components/banner/AppHeaderBanner.tsx Outdated Show resolved Hide resolved
docs/src/modules/components/AppTableOfContents.js Outdated Show resolved Hide resolved
docs/src/components/banner/AppHeaderBanner.tsx Outdated Show resolved Hide resolved
docs/notifications.json Outdated Show resolved Hide resolved
@oliviertassinari oliviertassinari changed the title [website] Survey 2022 [website] Developer survey 2022 Dec 11, 2022
@joserodolfofreitas @oliviertassinari
Oliviers suggestions from code review
6ef4157 
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Signed-off-by: José Rodolfo Freitas <joserodolfo.freitas@gmail.com>
@joserodolfofreitas
Update side banner message with olivier+danilo suggestion
fcbf8bb
@joserodolfofreitas
Prettier
86762be
@joserodolfofreitas @danilo-leal
Danilo's review on AppHeaderBanner.tsx
ba74077 
Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
Signed-off-by: José Rodolfo Freitas <joserodolfo.freitas@gmail.com>
danilo-leal
danilo-leal approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good ⎯ excited for this year's iteration 🙌

@joserodolfofreitas joserodolfofreitas merged commit c5ec6f6 into mui:master Dec 12, 2022
@oliviertassinari
Copy link
Member

oliviertassinari commented Dec 12, 2022 •
edited

Nice, very clean.

Edit: survey closed with 612db95.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danilo-leal danilo-leal danilo-leal approved these changes

@siriwatknp siriwatknp Awaiting requested review from siriwatknp

@mnajdova mnajdova Awaiting requested review from mnajdova

@oliviertassinari oliviertassinari Awaiting requested review from oliviertassinari

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@joserodolfofreitas @mui-bot @oliviertassinari @mnajdova @danilo-leal