[ChipDelete][joy] Add onDelete prop to ChipDelete #35412
Conversation
sai6855
changed the title
@mui/joy: parsed: +0.07% , gzip: +0.14% |
oliviertassinari
added
the
component: chip
|
@ZeeshanTamboli can you review this PR |
|
@ZeeshanTamboli updated code as described, but ci/circleci: checkout test is failing. i'm not able to fix it, can you check it once |
There was a problem hiding this comment.
IMO, we should also add a statement in the docs here: https://mui.com/joy-ui/react-chip/#delete-button to say:
The `onDelete` callback is fired on `ChipDelete` when the chip is deleted.
|
@ZeeshanTamboli updated changes also added onDelete prop description in docs. but test-types test is failing not sure why, it is asking to run yarn docs:typescript:formatted but when i ran yarn docs:typescript:formatted DeletableChip.tsx.preview file is got deleted. |
Then I would suggest to remove |
sai6855
requested review from
ZeeshanTamboli
and removed request for
siriwatknp
| }; | ||
|
|
||
| const handleKeyDelete = (event: React.KeyboardEvent<HTMLButtonElement>) => { | ||
| event.preventDefault(); |
There was a problem hiding this comment.
What is the use case for preventDefault()?
There was a problem hiding this comment.
handleKeyDelete is firing twice for 1 keypress , e.preventDefault() is preventing that
There was a problem hiding this comment.
Then it should be specific for those keys. Currently, TAB is stuck on the chip delete.
Screen.Recording.2565-12-15.at.11.35.18.mov
There was a problem hiding this comment.
Got it so e.prevantDefault() should be inside if block, since you are committing to the pr will you make the change or should I.
There was a problem hiding this comment.
Got it, I can push the change.
There was a problem hiding this comment.
Sorry, I just pushed it. Hope it's fine
There was a problem hiding this comment.
mnajdova
changed the title
Closes: #35188
This PR adds onDelete prop to ChipDelete component, onDelete fires when user clicks on component or presses Backspace or enter.