Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Update product icons #35413

Merged
merged 3 commits into from Dec 13, 2022
Merged

Conversation

danilo-leal
Copy link
Contributor

Updating the product icons after all the refinement and polish that @gerdadesign did on them to make sure both the shapes are more consistent and well-balanced 🙌

@danilo-leal danilo-leal added design This is about UI or UX design, please involve a designer website Pages that are not documentation-related, marketing-focused. labels Dec 9, 2022
@mui-bot
Copy link

mui-bot commented Dec 9, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-35413--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against 428d73b

@oliviertassinari
Copy link
Member

oliviertassinari commented Dec 11, 2022

A live comment comparing the difference:
Frame 1 (1)

  • Core: nothing I can think of
  • X: feels bigger, it seems to work
  • Templates: feels smaller, is it expected?
  • Design kit: feels smaller, is it expected? The contrast between the difference face could also maybe increased to better see the 3D shape.
  • Toolpad: feels smaller, is it expected? It's also harder to see the T shape

@siriwatknp siriwatknp removed their request for review December 12, 2022 05:26
@siriwatknp
Copy link
Member

siriwatknp commented Dec 12, 2022

@danilo-leal I don't think I am helpful on this PR 😅. Removed my self from the reviewer.

@danilo-leal
Copy link
Contributor Author

@oliviertassinari the cube sizes are the same throughout all the logos ⎯ the reason why X feels bigger is just because it has more cubes 😬 but agree that the Design Kits are a bit too dark ⎯ @gerdadesign maybe we can fallback to the previous colors?

@gerdadesign
Copy link
Member

gerdadesign commented Dec 12, 2022

Logo colors are updated! This color difference came from the old product logos in Figma vs what was live on MUI.

Re: sizing — we updated the core cube building block and how that was used to build the logos. So, the cube within the X logo and the cube within the Design Kits logo are now more consistent with each other (size and corner radius).

@danilo-leal
Copy link
Contributor Author

@gerdadesign @oliviertassinari logos updated per the new design ⎯ let me know if it's ready for merge 👌

@danilo-leal danilo-leal merged commit d8078d9 into mui:master Dec 13, 2022
@danilo-leal danilo-leal deleted the update-product-icons branch December 13, 2022 18:30
@oliviertassinari
Copy link
Member

oliviertassinari commented Dec 14, 2022

the cube sizes are the same throughout all the logos

@danilo-leal @gerdadesign I see, it feels like it's taken from the same scene now. It seems like a step forward 👍.


In the long run, I think that we could explore these two questions for these logos:

  1. Should we make the icons more distinguishable from one to the other? It's not necessarily obvious which product is which one based on the icon. We are now used to them, so I think that can make a difference quickly but what about our users?
  2. Should we make them distinguishable at a smaller resolution? I'm thinking of browser tab favicon and low-res media.

e.g. HashiCorp

Screenshot 2022-12-14 at 23 39 45

@danilo-leal
Copy link
Contributor Author

I really like the push at a very small size such as these ones! It will definitely be a challenge given the cube-stacking type of logo ⎯ but it's something we should try 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design This is about UI or UX design, please involve a designer website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants