Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alert] Update icon color in all variants #35414

Merged
merged 2 commits into from Dec 12, 2022

Conversation

danilo-leal
Copy link
Contributor

This PR makes the icon color within the Alerts use the main palette value. It not only looks better and more aligned with the title text color but it also now stays in parity with the Alerts on the Design Kits. Closes #35401

@danilo-leal danilo-leal added design: material This is about Material Design, please involve a visual or UX designer in the process component: alert This is the name of the generic UI component, not the React module! labels Dec 9, 2022
@danilo-leal danilo-leal requested a review from a team December 9, 2022 16:53
@mui-bot
Copy link

mui-bot commented Dec 9, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-35414--material-ui.netlify.app/

Details of bundle changes

Generated by 🚫 dangerJS against 7935719

Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Nice detailed enhancement.

@michaldudak michaldudak merged commit 5c7eab3 into mui:master Dec 12, 2022
@danilo-leal danilo-leal deleted the update-alert-icon-color branch December 12, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: alert This is the name of the generic UI component, not the React module! design: material This is about Material Design, please involve a visual or UX designer in the process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Alert] Icon color mismatch with Figma's design kit
4 participants