Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Improve Responsive App bar with Drawer demo #35418

Conversation

ZeeshanTamboli
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli commented Dec 10, 2022

Fixes #35351

Also updated the text color in dark mode in Responsive App bar with Drawer demo demo. It was not visible.

Check the demo in dark mode -
Before: https://mui.com/material-ui/react-app-bar/#responsive-app-bar-with-drawer
After: https://deploy-preview-35418--material-ui.netlify.app/material-ui/react-app-bar/#responsive-app-bar-with-drawer

I also approved the Argos build: https://app.argos-ci.com/mui/material-ui/builds/8116/31127253 (I think the font changed which is fine).

@ZeeshanTamboli ZeeshanTamboli added docs Improvements or additions to the documentation component: app bar This is the name of the generic UI component, not the React module! labels Dec 10, 2022
@ZeeshanTamboli ZeeshanTamboli changed the title Issue/35351 fix state handling mistake [docs] Improve Responsive App bar with Drawer demo Dec 10, 2022
@mui-bot
Copy link

mui-bot commented Dec 10, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-35418--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against 744f04b

@ZeeshanTamboli ZeeshanTamboli marked this pull request as ready for review December 10, 2022 11:51
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! These small fixes go a long way 👌

@ZeeshanTamboli ZeeshanTamboli merged commit dedc905 into mui:master Dec 12, 2022
@ZeeshanTamboli ZeeshanTamboli deleted the issue/35351-fix-state-handling-mistake branch December 12, 2022 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: app bar This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] State handling mistake
3 participants