Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Fix typo in FormControl API docs #35449

Merged
merged 2 commits into from Dec 12, 2022
Merged

[docs] Fix typo in FormControl API docs #35449

merged 2 commits into from Dec 12, 2022

Conversation

Spanishiwa
Copy link
Contributor

Hello, fixing a typo in the form control docs. thank you

@mui-bot
Copy link

mui-bot commented Dec 12, 2022 •
edited

Messages
📖 Netlify deploy preview: https://deploy-preview-35449--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against 7d945be

@Spanishiwa Spanishiwa marked this pull request as draft December 12, 2022 09:58
@Spanishiwa Spanishiwa changed the title Fix typo in form-control docs [doc] Fix typo in form-control docs Dec 12, 2022
@Spanishiwa Spanishiwa marked this pull request as ready for review December 12, 2022 10:13
@michaldudak
Copy link
Member

Thanks for correcting this! Could you please run yarn docs:api and commit the changes, so that the generated API docs also include this change?

@michaldudak michaldudak added the docs Improvements or additions to the documentation label Dec 12, 2022
@ZeeshanTamboli ZeeshanTamboli changed the title [doc] Fix typo in form-control docs [docs] Fix typo in form-control docs Dec 12, 2022
@Spanishiwa
Copy link
Contributor Author

Yes no problem, it is my mistake. I have ran yarn docs:api and committed the changes as requested. This is my first PR it is quite exciting

@ZeeshanTamboli ZeeshanTamboli changed the title [docs] Fix typo in form-control docs [docs] Fix typo in FormControl API docs Dec 12, 2022
ZeeshanTamboli
ZeeshanTamboli approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It's a great first pull request on MUI 👌 Thank you for working on it!

@ZeeshanTamboli ZeeshanTamboli merged commit b8341bb into mui:master Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeeshanTamboli ZeeshanTamboli ZeeshanTamboli approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Spanishiwa @mui-bot @michaldudak @ZeeshanTamboli