Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[InputLabel] Enable size prop overrides via TypeScript module augmentation #35460

Merged
merged 7 commits into from Dec 15, 2022
Merged

[InputLabel] Enable size prop overrides via TypeScript module augmentation #35460

merged 7 commits into from Dec 15, 2022

Conversation

MickaelAustoni
Copy link
Contributor

@MickaelAustoni MickaelAustoni commented Dec 13, 2022 •
edited

@mui-bot
Copy link

mui-bot commented Dec 13, 2022 •
edited

Messages
📖 Netlify deploy preview: https://deploy-preview-35460--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against 80b9d24

@zannager zannager added the package: types Specific to @mui/types label Dec 14, 2022
ZeeshanTamboli
ZeeshanTamboli reviewed Dec 14, 2022
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the CI?

@ZeeshanTamboli ZeeshanTamboli changed the title [Types] Add InputLabel props size overrides [InputLabel] Enable overrides for size prop Dec 14, 2022
@ZeeshanTamboli ZeeshanTamboli changed the title [InputLabel] Enable overrides for size prop [InputLabel] Enable TypeScript override for size prop Dec 14, 2022
@ZeeshanTamboli ZeeshanTamboli added typescript and removed package: types Specific to @mui/types labels Dec 14, 2022
@ZeeshanTamboli ZeeshanTamboli changed the title [InputLabel] Enable TypeScript override for size prop [InputLabel] Enable size prop overrides via TypeScript module augmentation Dec 15, 2022
ZeeshanTamboli
ZeeshanTamboli reviewed Dec 15, 2022
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will also need a test. You can refer #33856.

@ZeeshanTamboli ZeeshanTamboli added the PR: needs test The pull request can't be merged label Dec 15, 2022
@MickaelAustoni
Copy link
Contributor Author

Can you fix the CI?

We will also need a test. You can refer #33856.

Done !

ZeeshanTamboli
ZeeshanTamboli reviewed Dec 15, 2022
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to merge the updated master branch into this branch to fix the CI.

@ZeeshanTamboli ZeeshanTamboli removed the PR: needs test The pull request can't be merged label Dec 15, 2022
@MickaelAustoni
Copy link
Contributor Author

I think you need to merge the updated master branch into this branch to fix the CI.

The branch is already up to date

@ZeeshanTamboli
Copy link
Member

I think you need to merge the updated master branch into this branch to fix the CI.

The branch is already up to date

It's 942 commits behind - https://github.com/MickaelAustoni/material-ui/tree/input-label-props-size-overrides

@MickaelAustoni
Copy link
Contributor Author

I think you need to merge the updated master branch into this branch to fix the CI.

The branch is already up to date

It's 942 commits behind - https://github.com/MickaelAustoni/material-ui/tree/input-label-props-size-overrides

Oh yes my fork was not update sorry 😅

@ZeeshanTamboli ZeeshanTamboli added component: FormControl The React component component: text field This is the name of the generic UI component, not the React module! and removed component: FormControl The React component labels Dec 15, 2022
ZeeshanTamboli
ZeeshanTamboli approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! It's a great first pull request on MUI 👌 Thank you for working on it!

@ZeeshanTamboli ZeeshanTamboli merged commit 9e3d1db into mui:master Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeeshanTamboli ZeeshanTamboli ZeeshanTamboli approved these changes

Assignees
No one assigned
Labels
component: text field This is the name of the generic UI component, not the React module! typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MickaelAustoni @mui-bot @ZeeshanTamboli @zannager