[Tooltip][Joy] Fix arrow does not appear #35473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siriwatknp
added
component: tooltip
siriwatknp
commented
Dec 14, 2022
| @@ -4,7 +4,7 @@ import Tooltip from '@mui/joy/Tooltip'; | |||
|
|
|||
| export default function ArrowTooltips() { | |||
| return ( | |||
| <Tooltip title="Add" arrow> | |||
| <Tooltip title="Add" arrow open placement="right"> | |||
There was a problem hiding this comment.
This visual regression will help us preventing the regression in the future.
siriwatknp
commented
Dec 14, 2022
| // @ts-ignore `ref` is required for the 'root' slot | ||
| useForkRef(resolvedComponentsProps?.ref, name === 'root' ? parameters.ref : undefined), | ||
| ) as ((instance: any | null) => void) | null; | ||
| const ref = useForkRef(internalRef, resolvedComponentsProps?.ref, parameters.ref); |
There was a problem hiding this comment.
useForkRef can receive ...refs, no need to double it.
siriwatknp
commented
Dec 14, 2022
| parameters: (T extends 'root' ? { ref: React.ForwardedRef<any> } : {}) & { | ||
| parameters: (T extends 'root' // root slot must pass a `ref` as a parameter | ||
| ? { ref: React.ForwardedRef<any> } | ||
| : { ref?: React.ForwardedRef<any> }) & { |
There was a problem hiding this comment.
This allows the non-root slot to pass in ref directly.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #35472
Root cause
The
refinadditionalPropsis not called byuseSlotsoarrowRefis always null.Argos
change is expected.