[Chip] Fix hover and focus style with CSS Variables #35502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Signed-off-by: DimaAbr <13933191+DimaAbr@users.noreply.github.com>
DimaAbr
force-pushed
the
chip-broken-focus
branch
from
90d275e
to
8da1011
Compare
ZeeshanTamboli
added
bug 🐛
ZeeshanTamboli
changed the title
ZeeshanTamboli
changed the title
ZeeshanTamboli
approved these changes
Dec 16, 2022
|
Thanks! I ran into it while working with the chip. Figured I might as well chip in (sorry for the horrible pun) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the chip hover and focus styles when using the CSSVarsProvider.
There were some missing braces which caused calc not to work and resulted in way lower numbers. This should align the behavior between css vars and regular themes
Before: https://codesandbox.io/s/elegant-sound-v0os54?file=/src/App.tsx:0-2257
After: https://codesandbox.io/s/create-react-app-with-typescript-forked-556ttt?file=/src/App.tsx