Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] migration-v4 Select component onChange event type #35509

Merged

Conversation

tzynwang
Copy link
Contributor

@tzynwang tzynwang commented Dec 17, 2022

Found out the type definition of onChange from Select component is actually SelectChangeEvent<T> instead of React.SyntheticEvent when migrating. Update the related parts in the docs.

Screenshot 2022-12-17 at 6 22 55 PM

updated doc preview: https://deploy-preview-35509--material-ui.netlify.app/material-ui/migration/v5-component-changes/#update-event-type-typescript-3

@mui-bot
Copy link

mui-bot commented Dec 17, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-35509--material-ui.netlify.app/

@material-ui/core: parsed: +Infinity% , gzip: +Infinity%
@material-ui/lab: parsed: +Infinity% , gzip: +Infinity%
@material-ui/styles: parsed: +Infinity% , gzip: +Infinity%
@material-ui/private-theming: parsed: +Infinity% , gzip: +Infinity%
@material-ui/system: parsed: +Infinity% , gzip: +Infinity%
@material-ui/unstyled: parsed: +Infinity% , gzip: +Infinity%
@material-ui/utils: parsed: +Infinity% , gzip: +Infinity%
@mui/material-next: parsed: +Infinity% , gzip: +Infinity%
@mui/joy: parsed: +Infinity% , gzip: +Infinity%

Details of bundle changes

Generated by 🚫 dangerJS against b52a43e

@siriwatknp siriwatknp added the docs Improvements or additions to the documentation label Dec 19, 2022
@siriwatknp siriwatknp changed the title [docs] fix: migration-v4 Select component onChange event type [docs] migration-v4 Select component onChange event type Dec 19, 2022
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for your contribution!

Note: no need to update translation files.

@siriwatknp siriwatknp merged commit b3ef76f into mui:master Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants