[Fix] Bring experimental_sx back with error code
#35528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siriwatknp
added
package: system
|
mnajdova
reviewed
Dec 19, 2022
packages/mui-system/src/index.js
Outdated
| export function experimental_sx() { | ||
| throw new MuiError( | ||
| 'MUI: The `experimental_sx` has been moved to `theme.unstable_sx`.' + | ||
| 'You should remove the import and replace the usage with `theme.unstable_sx(…same value you pass to experimental_sx)` instead.', |
There was a problem hiding this comment.
Is there a specific reason why we don't use the same error message?
There was a problem hiding this comment.
I feel a bit strange linking the MUI system to Material UI docs.
There was a problem hiding this comment.
Alright fair enough. Should we keep ""MUI: The experimental_sx has been moved to theme.unstable_sx.For more details, see #35150" instead of the current value. There are three new error messages in error-codes.js
mnajdova
reviewed
Dec 19, 2022
docs/public/static/error-codes.json
Outdated
Comment on lines
21
to
24
| "20": "MUI: The `experimental_sx` has been moved to `theme.unstable_sx`.For more details, see https://github.com/mui/material-ui/pull/35150", | ||
| "21": "MUI: The `experimental_sx` has been moved to `theme.unstable_sx`.To migrate, see https://mui.com/material-ui/customization/theme-components/#the-sx-syntax-experimental", | ||
| "22": "MUI: The `experimental_sx` has been moved to `theme.unstable_sx`.You should remove the import and replace the usage with `theme.unstable_sx(…same value you pass to experimental_sx)` instead.", | ||
| "23": "MUI: The `experimental_sx` has been moved to `theme.unstable_sx`.For more details, see https://github.com/mui/material-ui/pull/35150." |
There was a problem hiding this comment.
Suggested change
| "20": "MUI: The `experimental_sx` has been moved to `theme.unstable_sx`.For more details, see https://github.com/mui/material-ui/pull/35150", | |
| "21": "MUI: The `experimental_sx` has been moved to `theme.unstable_sx`.To migrate, see https://mui.com/material-ui/customization/theme-components/#the-sx-syntax-experimental", | |
| "22": "MUI: The `experimental_sx` has been moved to `theme.unstable_sx`.You should remove the import and replace the usage with `theme.unstable_sx(…same value you pass to experimental_sx)` instead.", | |
| "23": "MUI: The `experimental_sx` has been moved to `theme.unstable_sx`.For more details, see https://github.com/mui/material-ui/pull/35150." | |
| "20": "MUI: The `experimental_sx` has been moved to `theme.unstable_sx`.For more details, see https://github.com/mui/material-ui/pull/35150." |
I believe this is sufficient now.
There was a problem hiding this comment.
Thanks, my bad. I thought that the script would reset and collect the new one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #35501
To prevent the import error for those who install Material UI 5.10.x without an explicit MUI system.