Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TableCell] Fix scope prop to be not set when a data cell is rendered within a table head #35559

Merged
merged 5 commits into from Dec 23, 2022
Merged

[TableCell] Fix scope prop to be not set when a data cell is rendered within a table head #35559

merged 5 commits into from Dec 23, 2022

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Dec 21, 2022 •
edited

fixes: #35031

@sai6855 sai6855 marked this pull request as draft December 21, 2022 10:06
@mui-bot
Copy link

mui-bot commented Dec 21, 2022 •
edited

Messages
📖 Netlify deploy preview: https://deploy-preview-35559--material-ui.netlify.app/

Details of bundle changes

Generated by 🚫 dangerJS against cb9591d

@sai6855 sai6855 marked this pull request as ready for review December 21, 2022 12:44
@sai6855
Copy link
Contributor Author

sai6855 commented Dec 21, 2022

@ZeeshanTamboli can you review this pr

@ZeeshanTamboli ZeeshanTamboli changed the title [TableCell] Fix scope prop in table cell [TableCell] Fix scope prop to be empty when it is a data cell within a table head Dec 21, 2022
@ZeeshanTamboli ZeeshanTamboli added bug 🐛 Something doesn't work accessibility a11y component: table This is the name of the generic UI component, not the React module! labels Dec 21, 2022
@ZeeshanTamboli ZeeshanTamboli changed the title [TableCell] Fix scope prop to be empty when it is a data cell within a table head [TableCell] Fix scope prop to be not set when it is a data cell within a table head Dec 21, 2022
@ZeeshanTamboli ZeeshanTamboli changed the title [TableCell] Fix scope prop to be not set when it is a data cell within a table head [TableCell] Fix scope prop to be not set when a data cell is rendered within a table head Dec 21, 2022
@sai6855
Copy link
Contributor Author

sai6855 commented Dec 21, 2022

@ZeeshanTamboli updated code as suggested

ZeeshanTamboli
ZeeshanTamboli approved these changes Dec 22, 2022
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sai6855 ! Looks good to me.

mnajdova
mnajdova approved these changes Dec 23, 2022
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution

@mnajdova mnajdova merged commit f4cb745 into mui:master Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

@ZeeshanTamboli ZeeshanTamboli ZeeshanTamboli approved these changes

Assignees
No one assigned
Labels
accessibility a11y bug 🐛 Something doesn't work component: table This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

scope prop on TableCell cannot be set as empty
4 participants
@sai6855 @mui-bot @mnajdova @ZeeshanTamboli