Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Slider] Exclude isRtl from Material UI's Slider props #35564

Merged
merged 1 commit into from Dec 23, 2022
Merged

[Slider] Exclude isRtl from Material UI's Slider props #35564

merged 1 commit into from Dec 23, 2022

Conversation

michaldudak
Copy link
Member

The Slider docs incorrectly list the isRtl prop, even though it is not used. Only the SliderUnstyled has this prop.

@michaldudak michaldudak added docs Improvements or additions to the documentation component: slider This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels Dec 21, 2022
@mui-bot
Copy link

mui-bot commented Dec 21, 2022 •
edited

Messages
📖 Netlify deploy preview: https://deploy-preview-35564--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against fff6dca

mnajdova
mnajdova approved these changes Dec 22, 2022
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@mnajdova mnajdova merged commit e984fc1 into mui:master Dec 23, 2022
@mnajdova mnajdova mentioned this pull request Dec 23, 2022
Merged
1 task
@michaldudak michaldudak deleted the slider-exclude-isrtl branch December 27, 2022 11:25
@ZeeshanTamboli ZeeshanTamboli mentioned this pull request Jan 21, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

Assignees
No one assigned
Labels
component: slider This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: material-ui Specific to @mui/material
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@michaldudak @mui-bot @mnajdova