Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Clarify comment about sortStability() use case #35570

Merged
merged 1 commit into from Dec 23, 2022
Merged

[docs] Clarify comment about sortStability() use case #35570

merged 1 commit into from Dec 23, 2022

Conversation

frontendlane
Copy link
Contributor

Created this PR following discussion at #34189 (comment).

@frontendlane frontendlane changed the title clarify comment about sortStability() use case clarify comment about sortStability() use case Dec 21, 2022
@mui-bot
Copy link

mui-bot commented Dec 21, 2022 •
edited

Messages
📖 Netlify deploy preview: https://deploy-preview-35570--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against dc7ebe4

@zannager zannager added docs Improvements or additions to the documentation component: pagination This is the name of the generic UI component, not the React module! labels Dec 21, 2022
siriwatknp
siriwatknp approved these changes Dec 22, 2022
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for the detailed explanation!

@mnajdova mnajdova changed the title clarify comment about sortStability() use case [core] Clarify comment about sortStability() use case Dec 23, 2022
@mnajdova mnajdova changed the title [core] Clarify comment about sortStability() use case [docs] Clarify comment about sortStability() use case Dec 23, 2022
@mnajdova mnajdova added component: table This is the name of the generic UI component, not the React module! and removed component: pagination This is the name of the generic UI component, not the React module! labels Dec 23, 2022
@mnajdova mnajdova merged commit e33b2f6 into mui:master Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

Assignees
No one assigned
Labels
component: table This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@frontendlane @mui-bot @siriwatknp @mnajdova @zannager