Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Force light theme mode when activePage is null #35575

Merged
merged 1 commit into from Dec 23, 2022
Merged

[docs] Force light theme mode when activePage is null #35575

merged 1 commit into from Dec 23, 2022

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented Dec 22, 2022

Fixes the need to use light computer mode or creating a wrapping theme in playground pages to avoid the following case:

Before:
Screenshot 2022-12-22 at 15 48 03

After:
Screenshot 2022-12-22 at 15 48 12

activePage does not exist for playground pages

@LukasTy
Force light theme mode when activePage is null
a2f49ba 
- `activePage` does not exist for playground pages
@LukasTy LukasTy added docs Improvements or additions to the documentation core Infrastructure work going on behind the scenes enhancement This is not a bug, nor a new feature labels Dec 22, 2022
@mui-bot
Copy link

mui-bot commented Dec 22, 2022 •
edited

Messages
📖 Netlify deploy preview: https://deploy-preview-35575--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against a2f49ba

@LukasTy LukasTy marked this pull request as ready for review December 22, 2022 15:12
siriwatknp
siriwatknp approved these changes Dec 23, 2022
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 In the future, the ThemeProvider that wraps all the pages might be removed.

@LukasTy
Copy link
Member Author

LukasTy commented Dec 23, 2022

👍 In the future, the ThemeProvider that wraps all the pages might be removed.

If it does, it would be great to double check how the playground reacts to that change. 👍

@LukasTy LukasTy merged commit 648e121 into mui:master Dec 23, 2022
@LukasTy LukasTy deleted the fix-playground-theme branch December 23, 2022 06:56
@LukasTy LukasTy mentioned this pull request Dec 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes docs Improvements or additions to the documentation enhancement This is not a bug, nor a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LukasTy @mui-bot @siriwatknp