[core] Remove need for scopePathnames #35584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
core
oliviertassinari
force-pushed
the
docs-side-nav-auto-path
branch
from
c4ad1bf
to
6be299e
Compare
|
oliviertassinari
force-pushed
the
docs-side-nav-auto-path
branch
2 times, most recently
from
49deae3
to
4878b6a
Compare
oliviertassinari
force-pushed
the
docs-side-nav-auto-path
branch
from
4878b6a
to
36ed34e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The notion of
scopePathnamesis painful, e.g. in https://github.com/mui/mui-x/pull/7213/files#diff-ee90840a476635e5e663e42e8bec44d8f102d933541525413da71ef646f60f19R59. "Rows" expand when "Row selection" is selected:https://deploy-preview-7213--material-ui-x.netlify.app/x/react-data-grid/row-selection/
The solution is to traverse the pages to find all the nodes that need to be expanded to have the active page visible.
ℹ️ This is a breaking change for MUI X and MUI Toolpad docs because of all the 🙈 code duplication in _app.js.