[docs] Fix layout shift with modal #35591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
bug 🐛
|
mnajdova
reviewed
Dec 26, 2022
| @@ -15,7 +15,7 @@ waiAria: https://www.w3.org/WAI/ARIA/apg/patterns/dialogmodal/ | |||
| Unstyled Modal is a utility component that renders its children in front of a backdrop. | |||
| This lets you create an element that your users must interact with before continuing in the parent application. | |||
|
|
|||
| ### Features | |||
| **Features**: | |||
There was a problem hiding this comment.
Suggested change
| **Features**: | |
| ### Features |
Would recommend reverting this, as this page structure is used in all base pages. We can discuss potential changes of the page structure in a dedicated PR.
There was a problem hiding this comment.
Oh, I actually started this PR by removing this H2 https://mui.com/base/react-modal/#customization and flatting the whole heading structure because it felt like it wasn't adding value. I mean, everything is about customization. e.g. How does it make sense to have "Performance" under "Customization"? But then I reverted to keep the changes focused.
mnajdova
reviewed
Dec 26, 2022
| @@ -126,6 +126,14 @@ In order to display an Unstyled Modal rendered on the server, you need to disabl | |||
|
|
|||
| {{"demo": "ServerModal.js", "defaultCodeOpen": false}} | |||
|
|
|||
| ## Position fixed elements | |||
|
|
|||
| The modal disables the page scrolling while open by setting the `overflow: hidden` CSS property on the relevant scroll container. | |||
There was a problem hiding this comment.
👍 nice I remember this mentioning on some pull request. It's nice to have now link to share.
mnajdova
approved these changes
Dec 26, 2022
Co-authored-by: Marija Najdova <mnajdova@gmail.com> Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix https://mui-org.slack.com/archives/C041SDSF32L/p1671799892568439.
It's simpler to review the change without whitespace: https://github.com/mui/material-ui/pull/35591/files?diff=unified&w=1.
Before: https://mui.com/material-ui/react-select/#basic-select
Screen.Recording.2022-12-23.at.13.25.32.mov
After: https://deploy-preview-35591--material-ui.netlify.app/material-ui/react-select/#basic-select
The new docs: https://deploy-preview-35591--material-ui.netlify.app/base/react-modal/#position-fixed-elements. I wanted to document this since forever.