Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Hide keyboard shortcut if no hover feature #35625

Merged

Conversation

oliviertassinari
Copy link
Member

Something that annoyed me while I used the demo "Copy" button on my phone. I have no keyboard so I can't use the shortcut.

Screenshot 2022-12-25 at 16 23 58

The solution relies on https://developer.mozilla.org/en-US/docs/Web/CSS/@media/any-hover. in the future, we might be able to use: w3c/csswg-drafts#3871.

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation core Infrastructure work going on behind the scenes labels Dec 25, 2022
@oliviertassinari oliviertassinari force-pushed the hide-keyboard-indication-if-no-hover branch from a860bef to a58856c Compare December 25, 2022 15:41
@mui-bot
Copy link

mui-bot commented Dec 25, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-35625--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against a58856c

@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label Dec 25, 2022
@mnajdova mnajdova merged commit ace9a1f into mui:master Dec 26, 2022
@oliviertassinari oliviertassinari deleted the hide-keyboard-indication-if-no-hover branch December 26, 2022 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work core Infrastructure work going on behind the scenes docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants