Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Fix header link layout shift and clash #35626

Merged
merged 1 commit into from Dec 26, 2022

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Dec 25, 2022

The bugs can be seen here: https://mui.com/material-ui/getting-started/faq/#why-are-the-colors-i-am-seeing-different-from-what-i-see-here

  1. Wrong vertical alignment between the two links
  2. Overlap possible between the two links

Screenshot 2022-12-25 at 16 50 16

  1. No reserved space for the links

Screenshot 2022-12-25 at 16 50 09

  1. Layout shift on hover
Screen.Recording.2022-12-25.at.16.51.55.mov

It's all solved: https://deploy-preview-35626--material-ui.netlify.app/material-ui/getting-started/faq/#why-does-component-x-require-a-dom-node-in-a-prop-instead-of-a-ref-object.

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work docs Improvements or additions to the documentation core Infrastructure work going on behind the scenes labels Dec 25, 2022
@mui-bot
Copy link

mui-bot commented Dec 25, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-35626--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against d9604af

Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work core Infrastructure work going on behind the scenes docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants