[docs] Fix layout shift when streaming the page #35627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
docs
|
github-actions
bot
added
the
PR: out-of-date
oliviertassinari
force-pushed
the
fix-layout-shift-streaming
branch
from
79a72f3
to
c665ec3
Compare
github-actions
bot
removed
the
PR: out-of-date
oliviertassinari
force-pushed
the
fix-layout-shift-streaming
branch
from
c665ec3
to
4d4896a
Compare
oliviertassinari
added a commit
that referenced
this pull request
Jan 2, 2023
The issue was first reported in https://search.google.com/search-console/mobile-usability/drilldown?resource_id=sc-domain%3Amui.com&item_key=CAk&hl=en I introduced this regression in #35627. I should have tested it more extensively.
|
Oops, I broke the layout with this PR, e.g. https://deploy-preview-35627--material-ui.netlify.app/material-ui/react-table/. Fixed in 8e067ee. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem can be seen in:
Screen.Recording.2022-12-25.at.17.13.23.mov
There is this intermediary layout shift:
It's detailed in depth in this blog post: https://twitter.com/jaffathecake/status/1149637428388360197 (from 8 years ago, but still true, and might be true forever).
I believe we are allowed to use CSS Grid https://caniuse.com/css-grid as it's compatible with our browser support.
Preview: https://deploy-preview-35627--material-ui.netlify.app/material-ui/react-autocomplete/