Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Fix anchor link in the card's docs and fix a typo #35634

Merged
merged 1 commit into from Dec 27, 2022
Merged

[docs] Fix anchor link in the card's docs and fix a typo #35634

merged 1 commit into from Dec 27, 2022

Conversation

ZeeshanTamboli
Copy link
Member

Found them while looking at issue #35588.

@ZeeshanTamboli ZeeshanTamboli added docs Improvements or additions to the documentation component: card This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy labels Dec 26, 2022
@mui-bot
Copy link

mui-bot commented Dec 26, 2022 •
edited

Messages
📖 Netlify deploy preview: https://deploy-preview-35634--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against 4598b86

@ZeeshanTamboli ZeeshanTamboli marked this pull request as ready for review December 26, 2022 12:29
@mnajdova mnajdova changed the title [Card][Joy] Fix anchor link in docs and a typo [Card][joy] Fix anchor link in docs and a typo Dec 26, 2022
mnajdova
mnajdova approved these changes Dec 26, 2022
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! The tags in the PR title should match the package name (lowercase), as the label for the package is: 'package: joy'. In this case, this is simply a docs update, so I would add only the [docs] tag and mention the component in the description.

@mnajdova mnajdova changed the title [Card][joy] Fix anchor link in docs and a typo [docs] Fix anchor link in the card's docs and fix a typo Dec 26, 2022
@ZeeshanTamboli ZeeshanTamboli merged commit ee7824d into mui:master Dec 27, 2022
@ZeeshanTamboli ZeeshanTamboli deleted the docs-joy-ui-card-component-fixes branch December 27, 2022 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

Assignees
No one assigned
Labels
component: card This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ZeeshanTamboli @mui-bot @mnajdova