[docs][joy] Improved readability on theme tokens page #35639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: badal <14058003+badalsaibo@users.noreply.github.com>
badalsaibo
changed the title
|
Comment on lines
+7
to
+8
| 1. [Low-level tokens](#low-level-tokens) | ||
| 2. [Global variant tokens](#global-variant-tokens) |
There was a problem hiding this comment.
IMO, unordered list is better for this:
Suggested change
| 1. [Low-level tokens](#low-level-tokens) | |
| 2. [Global variant tokens](#global-variant-tokens) | |
| - [Low-level tokens](#low-level-tokens) | |
| - [Global variant tokens](#global-variant-tokens) |
There was a problem hiding this comment.
Hi. I gave it a numbered list because of the description clearly mentioning two categories.
to develop its theme, consisting of two categories
An unordered list is also valid if future iterations would make require more than two categories.
Let me know what should I do. 😊
There was a problem hiding this comment.
An ordered list should be no problem in this case.
ZeeshanTamboli
changed the title
ZeeshanTamboli
added
docs
ZeeshanTamboli
changed the title
hbjORbj
approved these changes
Dec 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reading, wanted to navigate quickly b/w these two sections and couldn't do that.
So added that with this PR.