[docs] Fix demo code selection through copy shortcut key on Firefox browser #35670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ZeeshanTamboli
added
bug 🐛
ZeeshanTamboli
changed the title
ZeeshanTamboli
requested review from
siriwatknp,
mnajdova and
oliviertassinari
ZeeshanTamboli
changed the title
oliviertassinari
added
scope: docs-infra
ZeeshanTamboli
deleted the
issue/35645-shortcut-copy-command-not-working-on-firefox
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35645
The
window.getSelection()returns an empty string on Firefox browser for a text inside a form field i.e textarea due to which the check fails and copies the whole code text.See bug opened 22 years ago which isn't yet fixed: https://bugzilla.mozilla.org/show_bug.cgi?id=85686.
I copied the same logic as in mui/mui-x#6593 which works well.
Link to test after fix: https://deploy-preview-35670--material-ui.netlify.app/material-ui/react-menu/#main-content
The specs needs to clarify this: w3c/selection-api#83, w3c/selection-api#7