Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Drawer] not working since 5.10.17 #35793

Closed
2 tasks done
sbitenc opened this issue Jan 11, 2023 · 4 comments
Closed
2 tasks done

[Drawer] not working since 5.10.17 #35793

sbitenc opened this issue Jan 11, 2023 · 4 comments
Assignees
Labels
component: drawer This is the name of the generic UI component, not the React module! status: waiting for author Issue with insufficient information

Comments

@sbitenc
Copy link

sbitenc commented Jan 11, 2023

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Steps to reproduce 馃暪

Steps:

  1. Close sidebar
  2. Refresh Page
  3. Try to open sidebar via a button

using AppBar position="absolute" open={sidebarState}
and Toolbar

Current behavior 馃槸

Right now, i cannot click the menu bar open, as the mui sidebar is on top of my cursor. No clicks are propagated and the sidebar cannot open at all.

image

Expected behavior 馃

With 5.10.16, i can click the sidebar open button without a problem.
As you can see, the element can be easily inspected.

image

Context 馃敠

Updating @mui/material to latest version 5.11.4 or anything equal to or above 5.10.17 breaks my sidebar.

Your environment 馃寧

npx @mui/envinfo
brave browser

  System:
    OS: macOS 13.1
  Binaries:
    Node: 18.10.0 - /usr/local/bin/node
    Yarn: Not Found
    npm: 8.19.2 - /usr/local/bin/npm
  Browsers:
    Chrome: Not Found
    Edge: Not Found
    Firefox: Not Found
    Safari: 16.2
  npmPackages:
    @emotion/react: 11.10.5 => 11.10.5 
    @emotion/styled: 11.10.5 => 11.10.5 
    @mui/base:  5.0.0-alpha.113 
    @mui/core-downloads-tracker:  5.11.4 
    @mui/icons-material: 5.11.0 => 5.11.0 
    @mui/lab: 5.0.0-alpha.115 => 5.0.0-alpha.115 
    @mui/material: 5.11.4 => 5.11.4 
    @mui/private-theming:  5.11.2 
    @mui/styled-engine:  5.11.0 
    @mui/system:  5.11.4 
    @mui/types:  7.2.3 
    @mui/utils:  5.11.2 
    @mui/x-data-grid:  5.17.18 
    @mui/x-data-grid-pro: 5.17.18 => 5.17.18 
    @mui/x-date-pickers:  5.0.13 
    @mui/x-date-pickers-pro: ^5.0.13 => 5.0.13 
    @mui/x-license-pro:  5.17.12 
    @types/react: 18.0.26 => 18.0.26 
    react: 18.2.0 => 18.2.0 
    react-dom: 18.2.0 => 18.2.0 
    typescript: 4.9.4 => 4.9.4 
@sbitenc sbitenc added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jan 11, 2023
@gulicJan
Copy link

gulicJan commented Jan 11, 2023

Additional info to this issue:

image

By default we have isSidebarOpen set to true. On mount we check if we should hide the sidebar(small screen, before refresh the sidebar was also closed, etc.) and if so we set isSidebarOpen to false. In this case we're faced with the issue my colleague mentioned.

But if we set the default value for isSidebarOpen to false it works as it should.

Is it possible that Drawer component after the 5.10.17 update doesn't handle the transition between initial truthy state and next falsy state that well?

@zannager zannager added the component: drawer This is the name of the generic UI component, not the React module! label Jan 11, 2023
@mnajdova
Copy link
Member

It doesn't look like this bug report has enough info for one of us to reproduce it.

Please provide a CodeSandbox (https://material-ui.com/r/issue-template-latest), a link to a repository on GitHub, or provide a minimal code example that reproduces the problem.

Here are some tips for providing a minimal example: https://stackoverflow.com/help/mcve

@mnajdova mnajdova added status: waiting for author Issue with insufficient information and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 12, 2023
@mnajdova
Copy link
Member

It may be related to #35010, but having a reproduction would help with figuring out what's wrong.

@github-actions
Copy link

Since the issue is missing key information and has been inactive for 7 days, it has been automatically closed. If you wish to see the issue reopened, please provide the missing information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: drawer This is the name of the generic UI component, not the React module! status: waiting for author Issue with insufficient information
Projects
None yet
Development

No branches or pull requests

4 participants