[docs] Fix demos showing TypeScript instead of JavaScript #35850
+23
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
mj12albert
force-pushed
the
base-docs-code-variant
branch
from
5a3c24e to
36c0989
Compare
mj12albert
force-pushed
the
base-docs-code-variant
branch
from
36c0989 to
524a16d
Compare
oliviertassinari
approved these changes
Feb 6, 2023
oliviertassinari
changed the title
|
I have updated the PR title and description to focus on the problem we fix for users. We usually frame the changes around what's the problem, I think that throwing is very important to prevent regressions, but isn't the main purpose of this PR. |
|
I see, thanks for the edits 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally raised in #35741 (comment), the bug: https://mui.com/base/react-input/#introduction shows TypeScript while the developer is asking for JavaScript:
This PR fixes these bugs and throws an error if a TS demo is used directly instead of plain JS. It also fixes the export to CodeSandbox.