Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Slider] Miscellaneous improvements #35941

Merged
merged 7 commits into from
Feb 21, 2023
Merged

[Slider] Miscellaneous improvements #35941

merged 7 commits into from
Feb 21, 2023

Conversation

ZeeshanTamboli
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli commented Jan 25, 2023 •
edited

There are two things in this PR:

  • Remove the unnecessary React.Fragment wrapper from Material-UI Slider.
  • Reuse the valueToPercent method defined in the useSlider hook file, thus preventing duplicate code.

@ZeeshanTamboli ZeeshanTamboli added component: slider This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature labels Jan 25, 2023
@mui-bot
Copy link

mui-bot commented Jan 25, 2023 •
edited

Netlify deploy preview

https://deploy-preview-35941--material-ui.netlify.app/

Bundle size report

Details of bundle changes

Generated by 🚫 dangerJS against 1007293

@ZeeshanTamboli ZeeshanTamboli marked this pull request as ready for review January 25, 2023 08:11
@ZeeshanTamboli
Copy link
Member Author

@michaldudak @mnajdova This can be reviewed when you get time.

mnajdova
mnajdova approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The React.Fragment was added when migrating from SliderUnstyled to useSlider, it was an overlook from our side.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 21, 2023
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 21, 2023
@ZeeshanTamboli ZeeshanTamboli merged commit 2747d56 into mui:master Feb 21, 2023
@ZeeshanTamboli ZeeshanTamboli deleted the slider/miscellaneous-improvements branch February 21, 2023 14:06
siriwatknp pushed a commit to mnajdova/material-ui that referenced this pull request Feb 24, 2023
@ZeeshanTamboli @siriwatknp
[Slider] Miscellaneous improvements (mui#35941)
bad09ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

@michaldudak michaldudak Awaiting requested review from michaldudak

Assignees
No one assigned
Labels
component: slider This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ZeeshanTamboli @mui-bot @mnajdova