-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
[docs] Revise Joy UI "Input" page #35970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for taking on another one @LadyBluenotes ! It looks like many tests are failing. Whenever you submit a new PR, make sure that it runs and builds locally first. This will help prevent failing tests and broken deploy previews. In this case, it looks like we have a few issues:
Once you get this bad boy building and passing tests, then I'll circle back with a line-by-line review. 👍 |
🤦 I was wondering why the checks were failing. Thank you for pointing them out! |
It worked! When in doubt, run the command twice I guess. 🤷♂️ |
Woohoo! I'll make sure to run it at the end before pushing next time. Hopefully it was just this once it decided to be fussy :') |
Is there anything I need to update/edit for this page? |
Thanks @LadyBluenotes ! I made some copy edits throughout, mostly all stuff that's easier for me to just do myself than to try to explain and then make you do it. You can click on my Let's wait for a final review from @danilo-leal or @siriwatknp but I'd say this is probably good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 A lot better!
Hi @samuelsycamore,
I did a few edits on this one to make it (what I assume) is similar to what you had mentioned previously in the Typography doc. It looks like this one was already pretty much good to go - whoever originally wrote it did a great job at following your template!
I added a few things that I think may help with clarity for people reading the document. I did have one question, however. When looking at the component, I'm not sure if there is a way to determine what type of input is being used. For example, if you wanted to use this component in a form and the user was to input a password, would the developer have to pass a prop into the inner HTML element to specify the type? I was thinking about adding something to clarify this point, just because it was a question I had myself.
Let me know if there's any changes / edits I need to make!