[Tab] Add explicit return type to useTab #36046
Merged
+77
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
zannager
added
the
component: tabs
mnajdova
reviewed
Feb 8, 2023
|
|
||
| export interface UseTabReturnValue { | ||
| /** | ||
| * If `true`, the tab is disabled. |
There was a problem hiding this comment.
Suggested change
| * If `true`, the tab is disabled. | |
| * If `true`, the component will be selected. |
| */ | ||
| selected: boolean; | ||
| /** | ||
| * If `true`, the tab's focus is visible. |
There was a problem hiding this comment.
Suggested change
| * If `true`, the tab's focus is visible. | |
| * If `true`, the tab's focus will be visible. |
| */ | ||
| setFocusVisible: React.Dispatch<React.SetStateAction<boolean>>; | ||
| /** | ||
| * If `true`, the tab is disabled. |
There was a problem hiding this comment.
Suggested change
| * If `true`, the tab is disabled. | |
| * If `true`, the component will be disabled. |
| */ | ||
| disabled: boolean; | ||
| /** | ||
| * If `true`, the tab is active. |
There was a problem hiding this comment.
Suggested change
| * If `true`, the tab is active. | |
| * If `true`, the component will be active. |
mnajdova
approved these changes
Feb 10, 2023
oliviertassinari
added
typescript
package: base-ui
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UseTab return value interface
closes: useTab in #35933
preview: https://deploy-preview-36046--material-ui.netlify.app/base/api/use-tab/#return-value