Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[useTabsList] Add explicit return type #36048

Merged
merged 5 commits into from
Feb 10, 2023
Merged

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Feb 4, 2023

UseTabsList return value interface

closes useTabsList in #35933

preview: https://deploy-preview-36048--material-ui.netlify.app/base/api/use-tabs-list/#return-value

@mui-bot
Copy link

mui-bot commented Feb 4, 2023

Messages
📖 Netlify deploy preview: https://deploy-preview-36048--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against 685597c

@zannager zannager added the component: tabs This is the name of the generic UI component, not the React module! label Feb 6, 2023

export interface UseTabsListReturnValue {
/**
* The direction of the text.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* The direction of the text.
* If `true`, it will indicate that the text's direction in right-to-left.

@sai6855 sai6855 requested a review from mnajdova February 8, 2023 17:22
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@mnajdova mnajdova merged commit 1abbb28 into mui:master Feb 10, 2023
@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation typescript package: base-ui Specific to @mui/base labels Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tabs This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: base-ui Specific to @mui/base typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants