Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UseTabPanel] Add explicit return type #36053

Merged
merged 3 commits into from
Feb 10, 2023
Merged

[UseTabPanel] Add explicit return type #36053

merged 3 commits into from
Feb 10, 2023

Conversation

Shorifpatwary
Copy link
Contributor

This PR is part of this issue #35933

@mui-bot
Copy link

mui-bot commented Feb 4, 2023 •
edited

Netlify deploy preview

No updates.

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against 68759c9

@Shorifpatwary
Copy link
Contributor Author

yarn docs:api command doesn't generate any doc for this. BTW js docs added .......

@zannager zannager added the component: tabs This is the name of the generic UI component, not the React module! label Feb 6, 2023
mnajdova
mnajdova approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! The reason of why yarn docs:api was not working was because the types for the hooks were not exported from the component's root index.ts file at all.

@mnajdova mnajdova merged commit f385b5a into mui:master Feb 10, 2023
@mnajdova mnajdova mentioned this pull request Feb 15, 2023
Closed
15 tasks
@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation typescript labels Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

Assignees
No one assigned
Labels
component: tabs This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Shorifpatwary @mui-bot @mnajdova @oliviertassinari @zannager