[blog] Fix the look and feel of the media description #36069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
design
|
oliviertassinari
force-pushed
the
fix-blog-url-description
branch
from
745b4e8
to
6d1d866
Compare
oliviertassinari
force-pushed
the
fix-blog-url-description
branch
from
6d1d866
to
5428663
Compare
|
I'm curious about the reasoning for centered text 😬 Don't dislike it, just wondering if there's anything to be said aside from personal style here. |
|
@danilo-leal I have tried hard to not change the alignment, the issue is that I couldn't both make the caption out of the normal reading flow and still legible. |
danilo-leal
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the handling of the media caption in the blog posts:
Before: https://mui.com/blog/2022-tenerife-retreat/#destination
After: https://deploy-preview-36069--material-ui.netlify.app/blog/2022-tenerife-retreat/#destination
I noticed this working on #35839.