-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[useAutocomplete] Fix useAutocomplete
disabled prop not disabling the input
#36076
Conversation
|
@sai6855 note that if disabled option is set dynamically, for example if the user has a button that disables/enables disable hook -> trigger onMouseDown on input -> enable component -> popper stays open even if user clicks away |
can you provide a sandbox with the issue you described? you can use this template https://codesandbox.io/s/huxjvu?file=/demo.tsx |
useAutocomplete
disabled prop does not disable component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks!
@arnoldkokot It is not related to this bug or PR. Please create a new issue showing a reproduction if it's a bug. |
useAutocomplete
disabled prop does not disable componentuseAutocomplete
disabled prop not disabling the input
closes: #36055
Before: https://codesandbox.io/s/suspicious-dust-yxwwst?file=/src/App.tsx
After: https://codesandbox.io/s/wizardly-hugle-rsin57