Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Turn off job banner on docs #36080

Merged
merged 1 commit into from May 2, 2023
Merged

[docs] Turn off job banner on docs #36080

merged 1 commit into from May 2, 2023

Conversation

joserodolfofreitas
Copy link
Member

@joserodolfofreitas joserodolfofreitas commented Feb 6, 2023 •
edited

Summary

  • Add a toggle variable to turn off/on the Job ad.
  • Set the toggle to "off"

Follow up on #36074 (comment)

Preview (after)

https://deploy-preview-36080--material-ui.netlify.app/material-ui/getting-started/overview/

Before

image

@joserodolfofreitas joserodolfofreitas added the docs Improvements or additions to the documentation label Feb 6, 2023
@mui-bot
Copy link

mui-bot commented Feb 6, 2023 •
edited

Netlify deploy preview

https://deploy-preview-36080--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against 0f83f63

@joserodolfofreitas joserodolfofreitas mentioned this pull request Feb 6, 2023
Merged
1 task
@joserodolfofreitas joserodolfofreitas changed the title [docs] Add toggle for job banner on docs [docs] Turn off job banner on docs Feb 6, 2023
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 6, 2023
@samuelsycamore
Copy link
Member

Should we move forward with this?

@oliviertassinari oliviertassinari self-assigned this Apr 28, 2023
@oliviertassinari
Copy link
Member

oliviertassinari commented Apr 28, 2023 •
edited

  1. https://app.ashbyhq.com/reports/saved/9a0368b3-c6ec-46b9-86de-094c27d013a9 says that few applications are coming from this ad:

Screenshot 2023-04-29 at 00 43 50

  1. https://app.ashbyhq.com/reports/saved/3b85b418-7e7c-4bde-a54e-edb34b9d49af says that the passthrough rate for this source is pretty bad:

Screenshot 2023-04-29 at 00 42 45

But it could simply be because people check back again the career page before applying. I think that we can try to remove, and see how the metric in 1. evolve. This will improve the DX on the docs.

@oliviertassinari oliviertassinari added the scope: docs-infra Specific to the docs-infra product label Apr 28, 2023
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 28, 2023
@joserodolfofreitas joserodolfofreitas merged commit ad8f763 into mui:master May 2, 2023
18 checks passed
binh1298 pushed a commit to binh1298/material-ui that referenced this pull request May 17, 2023
@joserodolfofreitas @binh1298
[docs] Turn off job banner on docs (mui#36080)
5c8ed07
@oliviertassinari
Copy link
Member

But it could simply be because people check back again the career page before applying. I think that we can try to remove, and see how the metric in 1. evolve. This will improve the DX on the docs.

I haven't seen much impact after the removal, I doubt the ad banner was that impactful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@mnajdova mnajdova Awaiting requested review from mnajdova

@DanailH DanailH Awaiting requested review from DanailH

Assignees

@oliviertassinari oliviertassinari

Labels
docs Improvements or additions to the documentation scope: docs-infra Specific to the docs-infra product
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@joserodolfofreitas @mui-bot @samuelsycamore @oliviertassinari