Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Joy] Add order dashboard template #36081

Merged
merged 18 commits into from
Feb 14, 2023

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Feb 6, 2023

@siriwatknp siriwatknp added the design: joy This is about Joy Design, please involve a visual or UX designer in the process label Feb 6, 2023
@mui-bot
Copy link

mui-bot commented Feb 6, 2023

Netlify deploy preview

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against e4d0920

@siriwatknp siriwatknp marked this pull request as ready for review February 7, 2023 03:31
@siriwatknp siriwatknp requested review from danilo-leal and a team February 7, 2023 07:36
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love that, Jun! Thanks for setting it all up ⎯ interesting to see how streamlined it gets to build with Joy 😬 I've done some overall design uplift, going a bit sideways from the original reference (e.g., moved back the primary color to primary, put the font in Inter as it was with "Fire Sans" before, size, spacing, and variant tweaking throughout).

Comitting for now but I'll do a last pass before merging this one up!

@danilo-leal
Copy link
Contributor

Stray comment, though ⎯ I don't why exactly but on Firefox it looks entirely different than on Chromium... any idea?

Screen Shot 2023-02-10 at 11 14 45

@siriwatknp
Copy link
Member Author

@danilo-leal Can you check again? I pushed some changes to simplify the code. I think the templates should have as few customization as possible.

Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed just a couple more tweaks! Looking awesome 👌

@siriwatknp siriwatknp merged commit 7dc76a4 into mui:master Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design: joy This is about Joy Design, please involve a visual or UX designer in the process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants