Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[examples] Convert Next.js _document class components to function components #36109

Merged
merged 2 commits into from
Feb 24, 2023

Conversation

ossan-engineer
Copy link
Contributor

@ossan-engineer ossan-engineer commented Feb 8, 2023

Unless there is a special reason, it is better to use function components instead of class components.

@mui-bot
Copy link

mui-bot commented Feb 8, 2023

Netlify deploy preview

https://deploy-preview-36109--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against 42787bf

@michaldudak michaldudak added the examples Relating to /examples label Feb 9, 2023
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 15, 2023
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 16, 2023
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran it locally. Works well and it makes sense to have function components. This is better. Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Relating to /examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants